Skip to content

fix: prepare picomatch parser candidate for security review - #60

Draft
GSTJ wants to merge 1 commit into
masterfrom
fix/picomatch-parser-candidate
Draft

GSTJ wants to merge 1 commit into
masterfrom
fix/picomatch-parser-candidate

Conversation

@GSTJ

@GSTJ GSTJ commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Prepare candidate picomatch parser patches for the versions this project installs. This draft is blocked on independent security review and must not be merged or released.

Details

  • Adapts the shared Safe JSX candidate to picomatch 2.3.2 and 4.0.5, with exact installed parser hashes and dependency-path validation.
  • Preserves benign nested star reduction, escaped tokens, character classes and ordinary file globs in the compatibility checks.
  • Earlier candidates missed nested patterns. The final independent review returned no result because the provider blocked the request. No further adversarial review was attempted here.
  • The candidate audit gate deliberately fails pending review, including when the registry omits the advisory. GHSA-fc5q-39xc-vjpf is currently marked withdrawn; the original audit reported 200 paths, all resolved locally to the final candidate installations.
  • npm publication remains blocked by the previously reported authentication failure. No publication retry or secret request was made.

Testing steps

From a clean install, run:

pnpm install --frozen-lockfile
pnpm run lint
pnpm run format
pnpm run typecheck
pnpm run build
pnpm run test
pnpm run changelog:check
npm pack --dry-run
pnpm run security:check

The benign checks and full local suite pass. The last command must fail with the independent-review blocker. This is a tooling-only candidate; no native app behavior changed or was validated.

CLI recording and logs

Real CLI recording, benign checks and blocked security gate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant